Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Expense Claim): update of Outstanding Amount on Payment Entry submission (backport #1802) #1804

Merged
merged 4 commits into from
May 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 23, 2024

Fixes issues where the Outstanding Amount of Payment Entry Reference is not updated on its submission.


This is an automatic backport of pull request #1802 done by Mergify.

krantheman and others added 4 commits May 23, 2024 09:54
- all previous PEs should have outstanding amount at that point in time, should not become 0 at the end

- update on cancellation too

- avoid calling the fn if payment is made via JV

(cherry picked from commit 7387348)
@mergify mergify bot requested a review from ruchamahabal as a code owner May 23, 2024 09:54
@ruchamahabal ruchamahabal merged commit 3396aef into version-14-hotfix May 23, 2024
7 of 8 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-1802 branch May 23, 2024 10:36
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.28.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants