Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Expense Claim): update of Outstanding Amount on Payment Entry submission #1802

Merged
merged 4 commits into from
May 23, 2024

Conversation

krantheman
Copy link
Member

@krantheman krantheman commented May 22, 2024

Fixes issues where the Outstanding Amount of Payment Entry Reference is not updated on its submission.

Screenshots

Expense Claim

Paid with Total Amount Reimbursed Rs. 1000

image

Payment Entry

Before PR: Outstanding Amount remains Rs. 1000

image

After PR: Outstanding Amount updated to Rs. 0

image

@krantheman krantheman marked this pull request as ready for review May 22, 2024 12:47
- all previous PEs should have outstanding amount at that point in time, should not become 0 at the end

- update on cancellation too

- avoid calling the fn if payment is made via JV
@ruchamahabal ruchamahabal merged commit 78f68f3 into frappe:develop May 23, 2024
7 checks passed
ruchamahabal added a commit that referenced this pull request May 23, 2024
…1802

fix(Expense Claim): update of Outstanding Amount on Payment Entry submission (backport #1802)
ruchamahabal added a commit that referenced this pull request May 23, 2024
…1802

fix(Expense Claim): update of Outstanding Amount on Payment Entry submission (backport #1802)
@krantheman krantheman deleted the fix-outstanding-amount branch May 23, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants