Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Expense Claim): update of Outstanding Amount on Payment Entry submission (backport #1802) #1804

Merged
merged 4 commits into from
May 23, 2024
Merged

fix(Expense Claim): update of Outstanding Amount on Payment Entry submission (backport #1802) #1804

merged 4 commits into from
May 23, 2024

Commits on May 23, 2024

  1. fix(Expense Claim): update of Outstanding Amount on Payment Entry sub… 

    …mission

(cherry picked from commit 770ffdb)
    @krantheman @mergify
    krantheman authored and mergify[bot] committed May 23, 2024
    Configuration menu
    Copy the full SHA
    3ff82d8 View commit details
    Browse the repository at this point in the history

  2. fix: update all past Payment Entries outstanding amount 

    (cherry picked from commit 45882d2)
    @krantheman @mergify
    krantheman authored and mergify[bot] committed May 23, 2024
    Configuration menu
    Copy the full SHA
    3f17fee View commit details
    Browse the repository at this point in the history

  3. test: check if Payment Entry Outstaning Amount has been updated 

    (cherry picked from commit 81e6b8c)
    @krantheman @mergify
    krantheman authored and mergify[bot] committed May 23, 2024
    Configuration menu
    Copy the full SHA
    05e13a1 View commit details
    Browse the repository at this point in the history

  4. fix: update outstanding amount only in the current payment entry 

    - all previous PEs should have outstanding amount at that point in time, should not become 0 at the end

- update on cancellation too

- avoid calling the fn if payment is made via JV

(cherry picked from commit 7387348)
    @ruchamahabal @mergify
    ruchamahabal authored and mergify[bot] committed May 23, 2024
    Configuration menu
    Copy the full SHA
    cc4d718 View commit details
    Browse the repository at this point in the history