Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consider payment days = total working days in the last salary slip while calculating Gratuity (backport #1806) #1809

Merged
merged 5 commits into from
May 24, 2024
Merged

fix: consider payment days = total working days in the last salary slip while calculating Gratuity (backport #1806) #1809

merged 5 commits into from
May 24, 2024

Commits on May 24, 2024

  1. fix: consider payment days = total working days in the last salary sl… 

    …ip while calculating Gratuity

(cherry picked from commit 52835d2)
    @ruchamahabal @mergify
    ruchamahabal authored and mergify[bot] committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1675932 View commit details
    Browse the repository at this point in the history

  2. refactor: move gratuity calculation functions to the class 

    - to avoid passing around args repetitively

(cherry picked from commit c07543e)
    @ruchamahabal @mergify
    ruchamahabal authored and mergify[bot] committed May 24, 2024
    Configuration menu
    Copy the full SHA
    524ba64 View commit details
    Browse the repository at this point in the history

  3. refactor: remove unnecessary functions, improve readability 

    - make gratuity settings a class property to avoid refetching

- get rid of unnecessary variables

- extract complex conditions into bool functions

(cherry picked from commit 4b1437b)
    @ruchamahabal @mergify
    ruchamahabal authored and mergify[bot] committed May 24, 2024
    Configuration menu
    Copy the full SHA
    51a7f29 View commit details
    Browse the repository at this point in the history

  4. fix: only fetch required fields from gratuity slabs 

    (cherry picked from commit 6ac2da5)
    @ruchamahabal @mergify
    ruchamahabal authored and mergify[bot] committed May 24, 2024
    Configuration menu
    Copy the full SHA
    cb1b76a View commit details
    Browse the repository at this point in the history

  5. test: gratuity amount is consistent irrespective of the payment days 

    - remove unnecessary test

(cherry picked from commit e474d86)
    @ruchamahabal @mergify
    ruchamahabal authored and mergify[bot] committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4ed9fb6 View commit details
    Browse the repository at this point in the history