fix: filter out old allocation's carry-forwarded leaves while fetching leave details #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
force-pushed
the
fix-leave-balance
branch
from
42c89c7
to
964af9d
Compare
ruchamahabal
changed the title
ruchamahabal
changed the title
ruchamahabal
added a commit
that referenced
this pull request
Mar 22, 2023
fix: filter out old allocation's carry-forwarded leaves while fetching leave details (backport #411)
ruchamahabal
added
the
backport version-13-hotfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
While fetching allocation details for leave dashboard, all the previous carry forwarded records are being considered.
Only the record marked in green should be considered
Causing weird balance calculations 😵💫
Actual balance is 0
Fix
In the cf leaves query, add a condition to make sure only current allocation's leaves are being considered
The Ledger Period can vary in case of carry forwarded leaves
Ex: Allocation Period can be - 1st Jan 2023 to 31st Dec 2023
But carry forwarded leaves can have an early expiry (if they have to be used in the first 2-3 months)
So just comparing balance dates with Ledger dates won't help here
Edge case missed while fixing another edge case in #335