-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: v13 -> v14 migration issues #448
Merged
ruchamahabal
merged 7 commits into
frappe:develop
from
ruchamahabal:fix-migration-issues
Apr 17, 2023
Merged
fix: v13 -> v14 migration issues #448
ruchamahabal
merged 7 commits into
frappe:develop
from
ruchamahabal:fix-migration-issues
Apr 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #448 +/- ##
===========================================
- Coverage 72.89% 72.88% -0.02%
===========================================
Files 190 190
Lines 9789 9790 +1
===========================================
- Hits 7136 7135 -1
- Misses 2653 2655 +2
|
- while migrating from v13 if there is existing data > 140 chars in KRA, installation fails because patches cannot run before installation - add a new Link field key result area - copy KRA (Small Text)'s trimmed content to new key_result_area Link field
ruchamahabal
force-pushed
the
fix-migration-issues
branch
from
April 17, 2023 05:58
96a04d3
to
c0cf1e2
Compare
- since it does not need access to old schema now that key_result_area is added as a new field instead of changing the existing one
- patches updating some data should also run post install to avoid leaving data in an inconsistent state during v13 -> v14 migration
- if site is created from a backup, all the patches are set as patched in patch log - so even if the patch has not run on the site, the entry will be present in patch log
ruchamahabal
force-pushed
the
fix-migration-issues
branch
from
April 17, 2023 17:02
ca6a00e
to
21242fb
Compare
- add ignore mandatory flags wherever applicable - clear dt cache after altering table directly - convert subquery updates to join query updates in QB - make sure data doesn't get overwritten if patch runs more than once - remove unnecessary post install patches
ruchamahabal
force-pushed
the
fix-migration-issues
branch
from
April 17, 2023 17:08
21242fb
to
7612a8e
Compare
ruchamahabal
added a commit
that referenced
this pull request
Apr 17, 2023
fix: v13 -> v14 migration issues (backport #448)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixtures
Ignore mandatory fields while installing default salary components on app installation. Migration should not break if standard fields are customized as mandatory.
KRA patching
Problem:
Solution:
To ensure backward compatibility during installation:
Key Result Area
key_result_area
Link fieldkra
->key_result_area
Post Install Patches