Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use pip517 w/ flit #137

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Jul 9, 2023

Closes: #136

Confirmed as passing the error.

@blaggacao blaggacao marked this pull request as draft July 9, 2023 04:13
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (e6e06d5) 54.71% compared to head (cbd19e0) 54.79%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #137      +/-   ##
===========================================
+ Coverage    54.71%   54.79%   +0.07%     
===========================================
  Files           59       58       -1     
  Lines         3571     3566       -5     
===========================================
  Hits          1954     1954              
+ Misses        1617     1612       -5     

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blaggacao blaggacao marked this pull request as ready for review July 9, 2023 04:24
@nextchamp-saqib nextchamp-saqib merged commit 5f51dc3 into frappe:develop Jul 9, 2023
@blaggacao blaggacao deleted the fix-pip517 branch July 9, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New versions of pip deprecate use of setuptools in read-only directories
3 participants