Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tiny bench #1935

Merged
merged 28 commits into from
Jul 11, 2024
Merged

feat: tiny bench #1935

merged 28 commits into from
Jul 11, 2024

Conversation

tanmoysrt
Copy link
Member

@tanmoysrt tanmoysrt commented Jul 9, 2024

Goals

  • Only Mumbai, India region (configuration)
  • Need to ensure that tiny bench's site doesn't get scheduled only on the benches where larger plan's site is deployed
  • HTTP request timeout for 30 seconds (Manually)
  • Scheduler tick interval 10 minutes (Manually)
  • No skip auto update
  • Restrict the apps to only frappe apps
  • Need to ensure that other plan’s app doesn’t get scheduled to these bench’s server
  • In change plan, people can’t downgrade to 5 dollar one
  • Redesign the site creation page or maybe create a new page

Note

Currently, if user selects a non-allowed app or different region, the plan becomes non-selectable instead of completely removed from UI. It will be better to show the reason to user, why the plan is non-selectable/disabled.

  • Add testcases
    • Validation of downgrading to restricted site plan
    • Validation of restriction of disabling auto update for sites in public bench
    • Validation of specific allowed apps for site plan
    • Validation to check if larger plan's site doesn't get deployed to this plan's specific benches/servers
    • Validation to check if these specific plan (tiny plan)'s bench get deployed to only to the selected release group / bench specified in Site Plan

Tip

CPU time constraints for background job (For Later Version)

  • Track the CPU usage
  • Custom dequeue strategy to stop picking someone’s task if they hit quota

press/api/site.py Outdated Show resolved Hide resolved
press/press/doctype/site/site.py Outdated Show resolved Hide resolved
@tanmoysrt tanmoysrt marked this pull request as ready for review July 11, 2024 07:12
@tanmoysrt tanmoysrt merged commit fcb1158 into frappe:master Jul 11, 2024
5 checks passed
@tanmoysrt tanmoysrt deleted the tiny_bench branch July 11, 2024 11:31
@tanmoysrt tanmoysrt changed the title feat: tiny branch feat: tiny bench Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants