Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another orphan instance issue #106

Closed
parsonsmatt opened this issue Mar 31, 2022 · 2 comments
Closed

Another orphan instance issue #106

parsonsmatt opened this issue Mar 31, 2022 · 2 comments

Comments

@parsonsmatt
Copy link

We took quite a while debugging a build error where the Test.QuickCheck.Instances instance of Arbitrary Text was causing problems, and we could not figure out where it was coming from. After quite a lot of investigating, it was revealed to come from this package, where the module is imported here.

Between #91 and this issue, we've lost a considerable amount of time to orphan instances due to this package.

Orphan instances like these can be acceptable in test suites and executables, but they really can cause a lot of problems in libraries.

Would you be willing to accept a PR that tidies up the orphan instances and prevents them from leaking throughout the codebase?

@frasertweedale
Copy link
Owner

Thanks for the report.

I expect to have capacity in April to deal with these issues.

@parsonsmatt
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants