Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate integration of Fraunhofer-AISEC/cpg#205 #63

Closed
fwendland opened this issue Aug 27, 2020 · 4 comments · Fixed by #68
Closed

Evaluate integration of Fraunhofer-AISEC/cpg#205 #63

fwendland opened this issue Aug 27, 2020 · 4 comments · Fixed by #68

Comments

@fwendland
Copy link
Collaborator

Fraunhofer-AISEC/cpg#205 changes the creation of nodes in the CPG. Evaluate if the PR causes problems in codyze.
@fwendland
Copy link
Collaborator Author

fwendland commented Aug 27, 2020 •
edited
Loading

Integration test with Fraunhofer-AISEC/cpg#205 breaks the following tests:

  • de.fraunhofer.aisec.crymlin.WpdsTest#testWpdsOpensslSimplified
  • de.fraunhofer.aisec.crymlin.GraphTest#crymlinFunctionsTest
  • de.fraunhofer.aisec.crymlin.AnalysisServerQueriesTest#contextTest
  • de.fraunhofer.aisec.crymlin.OGMTest#countMethodDeclarations

@fwendland
Copy link
Collaborator Author

fwendland commented Aug 28, 2020 •
edited
Loading

Just checked against the branch for the PR. Well more work...

@oxisto
Copy link
Member

oxisto commented Aug 28, 2020 •
edited
Loading

It seems related to the non-existence of the file property, arising out of a wrong ordering of passes in CPG. See https://github.com/Fraunhofer-AISEC/cpg/issues

@oxisto
Copy link
Member

oxisto commented Aug 28, 2020

My proposal Fraunhofer-AISEC/cpg#220 explicitly sets this field as @Nullable (it implicitly already was), so codyze needs to deal with it accordingly.

This was referenced Aug 31, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Fraunhofer-AISEC/cpg v2.3.0
Update to CPG v2.3.0
2 participants
@fwendland @oxisto