Fix MSVC 2017 build errors #8
Conversation
chenm001
commented
Oct 6, 2020
chenm001
commented
- Crash on my non-AVX2 CPU
- Disable code page warning to avoid build failed (defaule level 'warning treated as error')
Environment:
* MSVS 2017
* Debug mode
Reason:
* Template member function in header file will generate duplicated code;
* There assign different CPU flag on cpp file;
* The linker choice one of template member function that generate for
AVX2 CPU
* As a result, the execute was crash due to BMI2 instruction SHLX
|
Concerning the crash on non-AVX2 CPUs. This only happens in debug mode, right? This is what we observed during development. Please let me know if this also affects release/relwithdebinfo builds. I think this is a compiler bug in MSVC rather than an issue with the software itself. Because its actually a compiler bug, and because it only impacts debugging on older CPU's I'd say we will not be fixing it. Thanks for providing the workaround solution. |
|
I think it is not a compiler bug, it is most probability software bugs. As details in my patch comment, the project uses a template in header files, the compiler will be generate both SSE4 and AVX2 version for template member fucntion .max(), and the linker choice one of instance into final execute file (I guess this is eligible for C++ standards). In Release and RelWithDebInfo mode, the compiler automatic inline these function into correct cpp files, so we can't see wrong CPU instruction across from them. My patch exact inline these member function in Debug mode, it is workaround for old CPU. |
chenm001
force-pushed
the
WIP
branch
2 times, most recently
from
7c995b7
to
8afd69d
Compare
Fix poc reuse (occasional test case failures) Closes fraunhoferhhi#8 and fraunhoferhhi#6 See merge request git/vvdec!59
