Rewrite for APIv3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Event model Implement Award model Implement Match model Implement Match methods Implement team years request Implement Medium model Implement Robot model Implement Media construction & requests Implement Robot requests & District models Implement District model and requests Implement Profile model and request Implement Alliance model & requests Implement DistrictPoints model and requests Implement Insights requests Implement OPRs requests Complete predictions model, add several requests Implement all remaining models and requests Some comment cleanup
|
Also, it's probably best to squash this into one commit when you merge. |
|
This looks really great! I am pleased to see that the builder design patter could be put to good use here. I would be happy to transfer the repository to you. |
|
You will need to delete your fork before I can perform the transfer: https://help.github.com/articles/about-repository-transfers/ |
|
Done. Didn't want to delete until this was merged. Thanks so much for your help! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I've rewritten the entire library to be compatible with TBA API v3.
The new library is instantiated differently than the prior version. Furthermore, as specified in #4, the rewrite uses a builder pattern to construct requests before sending them to TBA's API. For example:
I've ignored concerns about backward compatibility based on the facts that (a) APIv2 will be shuttered on January 1st, 2018, and (b) I am the only current user of this library and am prepared to make changes to my projects.
I've aggressively tested my implementation and I can't find any issues with it. However, since you've been using Go longer than I have, you may see problems with standards conformity or the like. Please point these out if they at all exist and I'll happily fix them.
Lastly, I'd like to humbly request that you transfer this repository to my account. I recognize that you are in college now and are probably very busy; I don't want to waste your time by submitting pull request after pull request as I continue developing this library. Please let me know if this is something you'd be comfortable with.