Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map docs and examples #86

Merged
merged 3 commits into from
Jun 4, 2018

Conversation

davidanthoff
Copy link
Member

Too rough to merge right now. Things that still need to happen:

  • Wait for VegaDatasets.jl with path support to be tagged
  • Make sure the one dot per zip map gets exported as png, not svg. Kills Chrome otherwise... This suggests we might need that as a per plot setting
  • Add some more maps

@coveralls
Copy link

coveralls commented Jun 3, 2018

Coverage Status

Coverage remained the same at 30.783% when pulling b570c09 on davidanthoff:map-doc-examples into 49ccbae on fredo-dedup:master.

@codecov-io
Copy link

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   30.78%   30.78%           
=======================================
  Files          16       16           
  Lines         562      562           
=======================================
  Hits          173      173           
  Misses        389      389
Impacted Files Coverage Δ
src/VegaLite.jl 82.75% <0%> (ø) ⬆️
src/dsl_helper_func/dsl_helper_func.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2e822...79c4ef1. Read the comment docs.

@davidanthoff davidanthoff changed the title WIP Add map docs and examples Add map docs and examples Jun 4, 2018
@davidanthoff davidanthoff merged commit 34b29b6 into queryverse:master Jun 4, 2018
@davidanthoff davidanthoff deleted the map-doc-examples branch June 4, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants