Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Git packages #115

Closed
sanmai-NL opened this issue Feb 11, 2023 · 6 comments
Closed

Support Git packages #115

sanmai-NL opened this issue Feb 11, 2023 · 6 comments
Assignees

Comments

@sanmai-NL
Copy link
Contributor

sanmai-NL commented Feb 11, 2023

In requirements.txt and modern package managers in pyproject.toml alike: e.g.,Pattern @ git+https://github.com/uob-vil/pattern.git.

When such a dependency is specified, it's incorrectly reported as unused by creosote 1.0.3.

@fredrikaverpil
Copy link
Owner

Thanks for reporting @sanmai-NL. Nice find.

@fredrikaverpil
Copy link
Owner

fredrikaverpil commented Mar 4, 2023

@sanmai-NL I'm thinking of how to support this. The repo name is not necessarily the same as the package name, so I don't think I can guess the package name only having the URI. I likely need to go to the URI and look for the package definition (e.g. the pyproject.toml, a setup.py or similar, and extract the name of the package from it. 🤔

@fredrikaverpil
Copy link
Owner

fredrikaverpil commented Mar 4, 2023

@sanmai-NL I think I've made this work now. Do you think you can give this a go and see if it works for you?

@fredrikaverpil
Copy link
Owner

@sanmai-NL please see if v2.1.0 fixes this for you.

@sanmai-NL
Copy link
Contributor Author

⛔️ Blocker: #114 (comment).

@fredrikaverpil fredrikaverpil self-assigned this Mar 6, 2023
@fredrikaverpil
Copy link
Owner

I'm closing this for now. We can reopen this if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants