Ignore rate limiter if no interval is supplied in order to avoid pseudo infinite loop #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if no interval is supplied, the ratelimiter will enter an infinite loop as the default interval is
0, meaningask_and_schedulewill continuously callProcess.send_after/3with a delay of0(see screenshot below)This results in unnecessarily high CPU when idling. My rMBP had around 60% - 80% CPU usage on idle.
Suggested solution is to completely bypass the rate limiter if there is no interval, and hook the consumer directly up to the producer