Detect proprietary toolchain #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for free-pdk-preview ready! Built with commit b92a4c7 |
|
Right now you are emphasizing the propriertary toolchain. Shouldn't it be the other way around? After all, we also want to promote the OSS toolchain. What I could imagine: Level 1: Projects with "free-pdk" topic and no *.PRE/PRJ files Level 1 could be emphasized (e.g. different color flair,callout or bold tag) and also pushed forward in sorting order somehow. |
|
Alright, this is how it looks now. Projects are sorted, and the tags are applied like you described. |
|
looks great! |
cpldcpu
approved these changes
Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #39 by adding a warning to projects using Padauk's proprietary IDE.
As described in the updated README, the additional API request we need to make per project quickly runs into the rate limit of the GitHub API. You can set a
GITHUB_TOKENenvironment variable to increase the rate limit when building the docs locally.Since we don't set a
GITHUB_TOKENvariable on netlify, the preview for this PR will not detect the proprietary toolchain.