feat: add ULCL config folder and compose yaml compliant with free5gc v3.4.1 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v3.4.1; adapt readme
|
I'll merge this now an add the requested change on a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that there was no up-to date configuration available for the ULCL configuration example.
Instead of linking to an old branch or to a patch file, I suggest creating a separate folder (
config/ULCL) and docker compose yaml (docker-compose-ulcl.yaml). This is similar to how the main free5gc repo handles this, and less error-prone in forgetting to incorporate updates to the config files :)I have also adapted the README accordingly.
Hope this is helpful to anyone!
Cheers,
LaumiH