Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: seperate all NFs Dockerfile to one #2

Merged
merged 6 commits into from
May 13, 2024
Merged

Docker: seperate all NFs Dockerfile to one #2

merged 6 commits into from
May 13, 2024

Conversation

brianchennn
Copy link
Contributor

@brianchennn brianchennn commented May 9, 2024 •
edited
Loading

About this PR

Add Makefile

  • build all NFs and webconsole: $ make
  • build one NF: $ make amf
  • build webconsole: $ make webui
  • remove all images from local: $ make clean

Share Dockerfile

  • This PR solved the pain points:
    • All NFs own its uniqle directory & Dockerfile, which make it hard to develop.
    • All NFs depends on image free5gc-base, but it takes about 100 seconds to build this base image.

@brianchennn brianchennn changed the title Docker: Seperate webconsole from free5gc-base Docker: seperate all NFs Dockerfile to one May 9, 2024
@andy89923
Copy link

@lyz508 Help review this PR! Thanks.

@brianchennn brianchennn force-pushed the pr/docker-seperate-webconsole branch from ba04530 to 9e66f11 Compare May 10, 2024 12:02
@ianchen0119 ianchen0119 merged commit 26c4ddd into free5gc:main May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy89923 andy89923 Awaiting requested review from andy89923

@ianchen0119 ianchen0119 Awaiting requested review from ianchen0119

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianchennn @andy89923 @ianchen0119 @lyz508