Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting PDU Session Container Type to UL #108

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

linouxis9
Copy link
Contributor

@linouxis9 linouxis9 commented Jul 24, 2024

Add support for setting PDU Session Container Type to UL in the GTP-U Extension Header.

This is required for PacketRusher and I would like to avoid using a gtp5g fork inside PacketRusher, I think it's better if this kind of work can be upstreamed :-)

I stuffed the field in FAR as I think it was the better fit, but if you have any suggestions on a better place, please say so.
The location of the field is a breaking change as well, so we might need to move that.

The related go-gtp5nl PR: free5gc/go-gtp5gnl#23

Thanks a lot!
Valentin

@tim-ywliu
Copy link
Collaborator

@linouxis9

You can use pdr->pdi->srcIntf to determine the direction.
If pdr->pdi->srcIntf == SRC_INTF_ACCESS means UL; pdr->pdi->srcIntf == SRC_INTF_CORE means DL.
Plz remove the new attr and replace it with pdr->pdi->srcIntf.

@linouxis9
Copy link
Contributor Author

Thanks a ton @tim-ywliu for the tip, I'll do the requested change!
Cheers,
Valentin

@tim-ywliu tim-ywliu merged commit 03afd80 into free5gc:master Nov 1, 2024
@linouxis9
Copy link
Contributor Author

Thanks a ton @tim-ywliu :-)!

@tim-ywliu
Copy link
Collaborator

tim-ywliu commented Nov 6, 2024

@linouxis9

You can refer to https://github.com/free5gc/go-upf/blob/main/internal/forwarder/gtp5g.go#L330 to pass PDI_SRC_INTF to gtp5g.

SRC_INTF_ACCESS (0) means uplink.
SRC_INTF_CORE (1) means downlink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants