fix: remove all the header in the correct way #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Roy-Hu
commented
May 9, 2023
Roy-Hu
commented
- perform ip4_rm_header before the gtp5g_push_header in the gtp5g_fwd_skb_ipv4 to prevent calculate the volume of the pushed header
- Not sure why pskb_may_pull in gtp1u_udp_encap_recv do not move the skb->data & skb-len forward hdrlen. Therefore, instead of deducting the Ipv4 & TCP header under GPRS tunneling protocol, it repeatedly deducts the hdrlen.
chen042531
reviewed
May 10, 2023
ianchen0119
reviewed
May 11, 2023
tim-ywliu
reviewed
May 16, 2023
tim-ywliu
reviewed
May 16, 2023
tim-ywliu
reviewed
May 16, 2023
tim-ywliu
reviewed
May 16, 2023
src/gtpu/pktinfo.c
Outdated
| } | ||
| volume = skb->len; | ||
| if (hdrlen == 0) { | ||
| // packets from N6 |
There was a problem hiding this comment.
// packets without gtp header
tim-ywliu
reviewed
May 16, 2023
src/gtpu/pktinfo.c
Outdated
| iph = ip_hdr(skb); | ||
| volume -= network_and_transport_header_len(skb_copy); | ||
| } else if (hdrlen > 0) { | ||
| // packets from N3/N9 |
There was a problem hiding this comment.
// packets with gtp header
tim-ywliu
reviewed
May 17, 2023
src/gtpu/pktinfo.c
Outdated
| volume = skb->len; | ||
| if (hdrlen == 0) { | ||
| // packets without gtp header | ||
| iph = ip_hdr(skb); |
There was a problem hiding this comment.
iph no use anymore and can be removed.
tim-ywliu
approved these changes
May 18, 2023
tim-ywliu
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.