Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade OpenAPI to R17 #117

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: Upgrade OpenAPI to R17 #117

wants to merge 16 commits into from

Conversation

pf-lin
Copy link
Contributor

@pf-lin pf-lin commented Aug 12, 2024

No description provided.

@ianchen0119
Copy link
Contributor

ianchen0119 commented Aug 14, 2024 •
edited
Loading

Hi @pf-lin ,

image

Please note that the content type of the response will be "multipart/related" if and only if the message has binary body part(s). Otherwise, the content type should be "application/json".

@ianchen0119
Copy link
Contributor

Also,
I found the schema of the errBody doesn't have the multipart tags.

This issue has already been fixed, please refer to the last two commits in openapi PR:
image

@andy89923 andy89923 self-assigned this Aug 15, 2024
andy89923
andy89923 reviewed Sep 4, 2024
View reviewed changes
internal/util/search_nf_service.go Outdated Show resolved Hide resolved
internal/sbi/processor/pdu_session.go Outdated Show resolved Hide resolved
a3828162
a3828162 approved these changes Sep 5, 2024
View reviewed changes
Copy link

@a3828162 a3828162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pf-lin pf-lin marked this pull request as ready for review September 8, 2024 16:57
TYuan0816
TYuan0816 reviewed Sep 10, 2024
View reviewed changes
Copy link

@TYuan0816 TYuan0816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

andy89923
andy89923 reviewed Sep 12, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
internal/context/sm_context.go Outdated Show resolved Hide resolved
internal/context/sm_context.go Outdated Show resolved Hide resolved
internal/sbi/consumer/amf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/pcf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/smf_service.go Outdated Show resolved Hide resolved
internal/sbi/processor/association.go Show resolved Hide resolved
internal/sbi/processor/datapath.go Show resolved Hide resolved
internal/sbi/processor/datapath.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy89923 andy89923 andy89923 left review comments

@TYuan0816 TYuan0816 TYuan0816 approved these changes

@a3828162 a3828162 a3828162 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@andy89923 andy89923

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pf-lin @ianchen0119 @andy89923 @a3828162 @TYuan0816