Support pdu session establishment IEs #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(more constants defined in TS 24.008 10.5.6.3 needed to be added, ref: edingroot/nas@68ffa38)
edingroot
changed the title
free5gc-org
reviewed
Aug 25, 2020
| @@ -25,7 +26,7 @@ func BuildGSMPDUSessionEstablishmentAccept(smContext *SMContext) ([]byte, error) | |||
| pDUSessionEstablishmentAccept.SetPDUSessionID(uint8(smContext.PDUSessionID)) | |||
| pDUSessionEstablishmentAccept.SetMessageType(nas.MsgTypePDUSessionEstablishmentAccept) | |||
| pDUSessionEstablishmentAccept.SetExtendedProtocolDiscriminator(nasMessage.Epd5GSSessionManagementMessage) | |||
| pDUSessionEstablishmentAccept.SetPTI(0x00) | |||
| pDUSessionEstablishmentAccept.SetPTI(smContext.Pti) | |||
There was a problem hiding this comment.
Hi, @edingroot
According to TS24.501 6.2.1
The PTI value should be set in every response from UE-requested transaction.
e.g., PTI should also be set in BuildGSMPDUSessionEstablishmentReject, BuildGSMPDUSessionModificationCommand ... so on and so forth.
free5gc-org
reviewed
Aug 25, 2020
| @@ -134,7 +163,7 @@ func BuildGSMPDUSessionReleaseCommand(smContext *SMContext) ([]byte, error) { | |||
| pDUSessionReleaseCommand.SetMessageType(nas.MsgTypePDUSessionReleaseCommand) | |||
| pDUSessionReleaseCommand.SetExtendedProtocolDiscriminator(nasMessage.Epd5GSSessionManagementMessage) | |||
| pDUSessionReleaseCommand.SetPDUSessionID(uint8(smContext.PDUSessionID)) | |||
| pDUSessionReleaseCommand.SetPTI(0x00) | |||
| pDUSessionReleaseCommand.SetPTI(smContext.Pti) | |||
There was a problem hiding this comment.
@edingroot ,
same PTI issue here
|
Hi @free5gc-org, |
free5gc-org
pushed a commit
that referenced
this pull request
Jan 18, 2021
…est #3) Feature/FR5GC-757 user plane routing rule config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR supports more IEs which are originally unknown in the PDU session establishment request handler, and add the corresponding parameters requested by the UE. In addition, the PTI field value of the PDU session estab. req. and accept should be the same, this is important to the (some) UE to recognize the estab. accept message.
Note: this PR should be MERGE ALONG WITH PR#3 in nas library in order to make it compilable.
Best,
Chi