Fix UPF nodeID parsing issue when using FQDN #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an FQDN is used as UPF node_id in SMF configuration, IP parsing fails and PFCP session is not established between SMF and UPF. To resolve this issue, and since there is no native way to check whether node_is is IPv4, IPv6 or an FQDN, we need to try a name resolution before parsing the IP. This issue was experienced in the docker version of free5gc: free5gc/free5gc-compose#9 Thanks to @hhoai we now know the root cause of the problem and the solution. The verification step will make sure that the nodeID is updated only when the DNS resolution succeeds.
|
As per the suggestion of @sh-sekigawa, resolving the NodeID as suggested here will make the FQDN case useless which is not the intended behaviour. The NodeIdType will never be a pfcpType.NodeIdTypeFqdn as the resolution happened before assigning the type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @free5gc-org,
When an FQDN is used as UPF
node_idin SMF configuration, IP parsing fails and PFCP session is not established between SMF and UPF. To resolve this issue, and since there is no native way to check whethernode_idis IPv4, IPv6 or an FQDN, we need to try a name resolution before parsing the IP.This issue was experienced in the docker version of free5gc: free5gc/free5gc-compose#9. This also provides a fix to issue free5gc/free5gc#111.
Thanks to @hhoai we now know the root cause of the problem and the solution. The verification step will make sure that the nodeID is updated only when the DNS resolution succeeds.
Cheers,