If non-subscribed UEs send RegistrationRequest, AMF does not return RegistrationReject and the resource will remain. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-ywliu
reviewed
Oct 27, 2022
| @@ -305,6 +305,10 @@ func HandleQueryAuthSubsData(request *httpwrapper.Request) *httpwrapper.Response | |||
| func QueryAuthSubsDataProcedure(collName string, ueId string) (map[string]interface{}, *models.ProblemDetails) { | |||
| filter := bson.M{"ueId": ueId} | |||
| data, pd := getDataFromDB(collName, filter) | |||
| if pd != nil && pd.Status == 404 { | |||
There was a problem hiding this comment.
Why need to add this? For changing the log level to Warn? It returns the same thing.
There was a problem hiding this comment.
It is better to replace 404 with http.StatusNotFound.
There was a problem hiding this comment.
And can combine these 2 if:
if pd != nil {
if pd.Status == http.StatusNotFound {
logger.DataRepoLog.Warnf("QueryAuthSubsDataProcedure err: %s", pd.Title)
} else {
logger.DataRepoLog.Errorf("QueryAuthSubsDataProcedure err: %s", pd.Detail)
}
return nil, pd
}
There was a problem hiding this comment.
I have made this modification because I have decided that in the case of per-user errors such as this one, a log level of Warning is more appropriate than Error.
And I have fixed and PR as you suggested.
…egistrationReject and the resource will remain.
RyuichiNamba-fj
force-pushed
the
fix/RegistrationReject
branch
from
b38526c
to
f04726a
Compare
tim-ywliu
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.