Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: update Web App termination procedure #96

Merged
merged 7 commits into from
May 16, 2024

Conversation

andy89923
Copy link
Collaborator

@andy89923 andy89923 commented May 9, 2024

Description

  • Use HTTP server with gin router
  • Add a waiting group to wait for all servers terminated
  • Send Dereg only when AF is registered
  • Fix the charging table sometimes a mismatch
  • Adjust Billing Server FTP server settings

TODO

  • Add Makefile

@ianchen0119
Copy link
Contributor

@andy89923
Is this PR ready to be reviewed? tks.

@andy89923 andy89923 marked this pull request as ready for review May 14, 2024 03:44
@andy89923
Copy link
Collaborator Author

@andy89923 Is this PR ready to be reviewed? tks.

@ianchen0119 This PR is now ready for review, thanks.

type FtpConfig struct {
Version int `json:"version"`
Accesses []Access `json:"accesses"`
Listen_address string `json:"listen_address"`

Passive_transfer_port_range PortRange `json:"passive_transfer_port_range"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add TODO: read from configuration file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add this TODO in #97

@ianchen0119 ianchen0119 merged commit f3f91f2 into free5gc:main May 16, 2024
3 checks passed
@andy89923 andy89923 deleted the perf/web-app branch May 29, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants