refactor: object lab (JS only) #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dario-DC
added
full stack cert
Labs Team
Dario-DC
added
status: waiting review
and removed
awaiting update
status: waiting review
labels
|
I have refactored the code as suggested @jdwilkin4 Personally, I would not include the several function calls and console.logs in the user stories. What do you think? |
jdwilkin4
reviewed
Sep 6, 2024
|
Just saw that you put the waiting update label on this. What should be updated? @jdwilkin4 |
|
Based on your comment here, it seemed like you wanted to make some updates. if you don't want to make any more changes, though then this can go in 👍 |
|
Sorry about the confusion. I did not include the last part of the code (console.logs and other function calls) in the user stories and I was asking if that was fine. |
jdwilkin4
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Related to #429
Since the block dedicated to functions has been moved before this one, I've modified the lab to use a function.