Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

fix(challenges): small edit to correct semantic issues #303

Merged
merged 1 commit into from
Sep 6, 2018
Merged

fix(challenges): small edit to correct semantic issues #303

merged 1 commit into from
Sep 6, 2018

Conversation

dougouverson
Copy link
Contributor

@dougouverson dougouverson commented Sep 4, 2018

should have said elements and not tags

Description

Pre-Submission Checklist

  • Your pull request targets the dev branch.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
  • All new and existing tests pass the command npm test.
  • Use npm run commit to generate a conventional commit message.
    Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
  • The changes were done locally on your machine and NOT GitHub web interface.
    If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

  • Tested changes locally.

should have said elements and not tags
@dougouverson
Copy link
Contributor Author

The only pace I explicitly edited file was on line 2487: https://github.com/freeCodeCamp/curriculum/pull/303/files#diff-a814213cd8bd54104c2f7b58cd36ce65L2487
The other edits must have taken place when running test.

@scissorsneedfoodtoo
Copy link
Contributor

✨ ✨ ✨ Awesome! Congratulations on your first contribution to freeCodeCamp! ✨ ✨ ✨

Thank you for submitting a PR for this, @dougouverson. Great catch here. Sorry again about all the trouble you went through with the local setup, but I'm glad it's sorted and you were able to improve this challenge.

Happy coding!

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit 322bf80 into freeCodeCamp:dev Sep 6, 2018
@dougouverson
Copy link
Contributor Author

dougouverson commented Sep 6, 2018

Thank you @scissorsneedfoodtoo I learned much. I look forward to submitting more PRs in the future. The community is great!

@dougouverson
Copy link
Contributor Author

I noticed that change is not showing up on page. Is this a caching issue? I did clear browser cache - fyi.

@scissorsneedfoodtoo
Copy link
Contributor

@dougouverson, it will take some time to show up on the live site. Usually what happens is that we merge fixes for about a week or two before pushing them to production. I think we'll be doing that soon, so keep an eye out for your fix!

@dougouverson
Copy link
Contributor Author

dougouverson commented Sep 7, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants