Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

fix(challenges): changed description in basic css lesson #315

Merged
merged 2 commits into from
Sep 26, 2018
Merged

fix(challenges): changed description in basic css lesson #315

merged 2 commits into from
Sep 26, 2018

Conversation

mul53
Copy link
Contributor

@mul53 mul53 commented Sep 14, 2018 •
edited
Loading

Description

Changed the text from HTML to CSS in basic-css.json

Pre-Submission Checklist

  • Your pull request targets the dev branch.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
  • All new and existing tests pass the command npm test.
  • Use npm run commit to generate a conventional commit message.
    Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
  • The changes were done locally on your machine and NOT GitHub web interface.
    If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

  • Tested changes locally.
  • Addressed currently open issue

Closes #314

@mul53
Copy link
Contributor Author

mul53 commented Sep 14, 2018

When i made the commit to my branch, prettier formatted the file causing many changes. Was there an error?

@mul53 mul53 closed this Sep 14, 2018
@mul53 mul53 deleted the fix/lesson-basic-css branch September 14, 2018 16:23
@mul53 mul53 restored the fix/lesson-basic-css branch September 14, 2018 16:25
@mul53
Copy link
Contributor Author

mul53 commented Sep 14, 2018

Sorry accidentally closed the pr

@mul53 mul53 reopened this Sep 14, 2018
@scissorsneedfoodtoo
Copy link
Contributor

@mul53, thank you for taking the time to improve this challenge. Did some reading about :root, and while I agree that the description could use some work, I'm not sure if the analogy works here. I'm not sure it's accurate to describe the :root as a container, and that it would be better to expand more on how :root works when defining global CSS variables.

Maybe we could replace that paragraph with something like the following:

<code>:root</code> is a <dfn>pseudo-class</dfn> selector that matches the root element of the document, usually the <code><html></code> element. By creating your variables in <code>:root</code>, they will be available globally and can be accessed from any other selector later in the style sheet.

This is just a suggestion, though. Let me know what you think and if you have any other ideas! Also, @RandellDawson, what do you think? I saw your comment in #314 and thought you might be able to help improve this description.

@RandellDawson
Copy link
Member

This is just a suggestion, though. Let me know what you think and if you have any other ideas! Also, @RandellDawson, what do you think? I saw your comment in #314 and thought you might be able to help improve this description.

@scissorsneedfoodtoo I think your latest suggestion looks good. I am fine with it.

@ghost ghost mentioned this pull request Sep 16, 2018
Closed
7 tasks
@mul53
Copy link
Contributor Author

mul53 commented Sep 16, 2018 •
edited
Loading

That's a good description, it defines the :root selector well. I will add the description to the file. Is that fine @scissorsneedfoodtoo ?

@scissorsneedfoodtoo
Copy link
Contributor

@mul53, so sorry for the late response. Yes, please go ahead and update the description in the file when you can!

After updating the file, you can add it just like before with git add challenges/01-responsive-web-design/basic-css.json. Then, use git commit --amend, edit the commit message to mention you added a description rather than fix a typo, and exit out of the editor. That way your PR will have just one commit message rather than two. Finally, force push to your branch with git push -f origin fix/lesson-basic-css and we'll see the changes reflected here.

Let us know if there's anything we can help with!

@mul53 mul53 changed the title fix(challenges): typo in basic css lesson fix(challenges): changed description in basic css lesson Sep 21, 2018
@mul53
Copy link
Contributor Author

mul53 commented Sep 21, 2018

@scissorsneedfoodtoo, i have made the changes and changed the description for the pr and the issue.

@scissorsneedfoodtoo
Copy link
Contributor

Sorry @mul53, but I'm not seeing the changes in your latest commit.

Also, I realize that I might not have been clear in my last comments where the description of :root should go within the challenge description. Here's what I'm thinking:

"description": [
        "When you create a variable, it becomes available for you to use inside the element in which you create it. It also becomes available within any elements nested within it. This effect is known as <dfn>cascading</dfn>.",
        "Because of cascading, CSS variables are often defined in the <dfn>:root</dfn> element.",
        "<code>:root</code> is a <dfn>pseudo-class</dfn> selector that matches the root element of the document, usually the <code><html></code> element. By creating your variables in <code>:root</code>, they will be available globally and can be accessed from any other selector later in the style sheet.",
        "<hr>",
        "Define a variable named <code>--penguin-belly</code> in the <code>:root</code> selector and give it the value of <code>pink</code>. You can then see how the value will cascade down to change the value to pink, anywhere that variable is used."
      ],

Sorry for the trouble, but would you mind trying to update the challenge description again? You can copy and paste the description array above into your editor and follow the steps above. Please let us know if you have any problems!

@mul53
Copy link
Contributor Author

mul53 commented Sep 23, 2018

@scissorsneedfoodtoo it's alright, i wanna help. I have made the changes, its on line 5317.

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit 754d4a6 into freeCodeCamp:dev Sep 26, 2018
@scissorsneedfoodtoo
Copy link
Contributor

✨ ✨ ✨ Awesome! Congratulations on your first contribution to freeCodeCamp! ✨ ✨ ✨

Thank you for submitting a PR for this issue, @mul53, and for taking the time to go back and make changes. We're all really looking forward to your next contribution!

Also, thank you for helping us with the new challenge description, @RandellDawson.

@scissorsneedfoodtoo scissorsneedfoodtoo mentioned this pull request Sep 26, 2018
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change description in lesson Basic CSS: Cascading CSS variables, :root definition and usage
3 participants
@mul53 @scissorsneedfoodtoo @RandellDawson