Migrate CoffeeScript to JavaScript #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon04
force-pushed
the
decaffeinate
branch
3 times, most recently
from
c85003b
to
2fa5853
Compare
|
do you want help with this? how are you converting coffee files to javascript? |
Help is welcome, I'm not actively working on this at the moment.
See #1441 (comment) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
assets/javascripts/app/app.js
Outdated
| return ( | ||
| file && | ||
| file.indexOf("devdocs") !== -1 && | ||
| file.indexOf(".js") === file.length - 3 |
Check failure
Code scanning / CodeQL
Incorrect suffix check
assets/javascripts/lib/page.js
Outdated
Comment on lines
207
to
240
| path = path | ||
| .replace(/\/\(/g, "(?:/") | ||
| .replace( | ||
| /(\/)?(\.)?:(\w+)(?:(\(.*?\)))?(\?)?/g, | ||
| function (_, slash = "", format = "", key, capture, optional) { | ||
| var str; | ||
| keys.push({ | ||
| name: key, | ||
| optional: !!optional, | ||
| }); | ||
| str = optional ? "" : slash; | ||
| str += "(?:"; | ||
| if (optional) { | ||
| str += slash; | ||
| } | ||
| str += format; | ||
| str += capture || (format ? "([^/.]+?)" : "([^/]+?)"); | ||
| str += ")"; | ||
| if (optional) { | ||
| str += optional; | ||
| } | ||
| return str; | ||
| } | ||
| ) | ||
| .replace(/([\/.])/g, "\\$1") |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
|
Migration seems to be successful. Let's give it a try. I'll keep an eye on https://devdocs.sentry.io/issues/ to spot and fix potential bugs... |
|
Sentry seems pretty calm. Nice work, @simon04! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm migrating one after another CoffeeScript file to JavaScript using https://decaffeinate-project.org/repl/.
Fixes #1197.