Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beta] Applied Accessibility - Test fails to check for closing </header> tag #16414

Closed
Asjas opened this issue Jan 5, 2018 · 2 comments
Closed

[Beta] Applied Accessibility - Test fails to check for closing </header> tag #16414

Asjas opened this issue Jan 5, 2018 · 2 comments
Labels
help wanted Open for all. You do not need permission to work on these.

Comments

@Asjas
Copy link
Contributor

Asjas commented Jan 5, 2018 •
edited

Challenge Name

https://beta.freecodecamp.org/en/challenges/applied-accessibility/make-screen-reader-navigation-easier-with-the-header-landmark

Issue Description

Test passes if you use an opening <header> tag and leave out an closing </header> tag. The test should check if the <header> tag is being closed.

Browser Information

  • Browser Name, Version: Crhome, Version 63.0.3239.108 (Official Build) (64-bit)
  • Operating System: Windows 10 Pro
  • Mobile, Desktop, or Tablet: Desktop

Your Code

<body>

  <header>
    <h1>Training with Camper Cat</h1>
    

  <main>
    <section id="stealth">
      <h2>Stealth &amp; Agility Training</h2>
      <article><h3>Climb foliage quickly using a minimum spanning tree approach</h3></article>
      <article><h3>No training is NP-complete without parkour</h3></article>
    </section>
    <section id="combat">
      <h2>Combat Training</h2>
      <article><h3>Dispatch multiple enemies with multithreaded tactics</h3></article>
      <article><h3>Goodbye world: 5 proven ways to knock out an opponent</h3></article>
    </section>
    <section id="weapons">
      <h2>Weapons Training</h2>
      <article><h3>Swords: the best tool to literally divide and conquer</h3></article>
      <article><h3>Breadth-first or depth-first in multi-weapon training?</h3></article>
    </section>
  </main>
</body>

Screenshot

incorrect
@Asjas Asjas changed the title [Beta] Applied Accessibility - Test isn't checking for closing html tag [Beta] Applied Accessibility - Test fails to check for closing </header> tag Jan 6, 2018
@raisedadead raisedadead added beta help wanted Open for all. You do not need permission to work on these. labels Jan 6, 2018
@anhtran1906
Copy link
Contributor

@raisedadead I could take on this since I already submitted a similar PR at #16575. However, #16417 is also related to this issue and I'd like to fix these 2 issues in 1 commit. Could you advise me on how I could do this? Thank you!

@raisedadead
Copy link
Member

Sure, will leave comments on the PR.

anhtran1906 added a commit to fccSeniorSeminar/freeCodeCamp that referenced this issue Jan 26, 2018
@anhtran1906
fix(seed): Add test cases for closing tags
036f6cf 
Added test cases with assert statements

BREAKING CHANGE: no

Closes freeCodeCamp#16415
Closes freeCodeCamp#16424
Closes freeCodeCamp#16423
Closes freeCodeCamp#16422
Closes freeCodeCamp#16420
Closes freeCodeCamp#16419
Closes freeCodeCamp#16417
Closes freeCodeCamp#16414
@anhtran1906 anhtran1906 mentioned this issue Jan 26, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@raisedadead @Asjas @anhtran1906