Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beta] Applied Accessibility - Tests fails to check for the closing </a> tag #16424

Closed
Asjas opened this issue Jan 6, 2018 · 4 comments
Closed

[Beta] Applied Accessibility - Tests fails to check for the closing </a> tag #16424

Asjas opened this issue Jan 6, 2018 · 4 comments
Labels
help wanted Open for all. You do not need permission to work on these.

Comments

@Asjas
Copy link
Contributor

Asjas commented Jan 6, 2018

Challenge Name

https://beta.freecodecamp.org/en/challenges/applied-accessibility/give-links-meaning-by-using-descriptive-link-text

Issue Description

This challenge has a issue where it isn't checking if the closing </a> is being used. You can replicate this by moving the opening <a> tag and deleting the closing </a> tag. The test will pass but it shouldn't do so.

The test needs to check if the closing </a> tag is also being used.

Browser Information

  • Browser Name, Version: Chrome, Version 63.0.3239.108 (Official Build) (64-bit)
  • Operating System: Windows 10 Pro
  • Mobile, Desktop, or Tablet: Desktop

Your Code

<body>
  <header>
    <h1>Deep Thoughts with Master Camper Cat</h1>
  </header>
  <article>
    <h2>Defeating your Foe: the Red Dot is Ours!</h2>
    <p>Felines the world over have been waging war on the most persistent of foes. This red
 nemesis combines both cunning stealth and lightening speed. But chin up, fellow 
fighters, our time for victory may soon be near. Click here for <a href="">information
 about batteries</p>
  </article>
</body>

Screenshot

achor
@vkWeb
Copy link
Member

vkWeb commented Jan 6, 2018

Confirmed!

@ooade
Copy link

ooade commented Jan 8, 2018

That's an issue on this line. A direct comparison should fix that... Probably

$('a').text().trim() == 'information about batteries'

@raisedadead raisedadead added help wanted Open for all. You do not need permission to work on these. type: tests labels Jan 11, 2018
@ghost
Copy link

ghost commented Jan 19, 2018

I have a branch with this issue fixed. If no one else is working on it, I'll submit a PR with the fix being what @ooade suggested.

@vkWeb
Copy link
Member

vkWeb commented Jan 19, 2018 •
edited

@0x0936 Go ahead if you have the fix ready.

anhtran1906 added a commit to fccSeniorSeminar/freeCodeCamp that referenced this issue Jan 26, 2018
@anhtran1906
fix(seed): Add test cases for closing tags
036f6cf 
Added test cases with assert statements

BREAKING CHANGE: no

Closes freeCodeCamp#16415
Closes freeCodeCamp#16424
Closes freeCodeCamp#16423
Closes freeCodeCamp#16422
Closes freeCodeCamp#16420
Closes freeCodeCamp#16419
Closes freeCodeCamp#16417
Closes freeCodeCamp#16414
@anhtran1906 anhtran1906 mentioned this issue Jan 26, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@raisedadead @Asjas @ooade @vkWeb