Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beta] Applied Accessibility - Tests fails to check for closing </audio> tag #16419

Closed
Asjas opened this issue Jan 6, 2018 · 5 comments
Closed

[Beta] Applied Accessibility - Tests fails to check for closing </audio> tag #16419

Asjas opened this issue Jan 6, 2018 · 5 comments
Labels
help wanted Open for all. You do not need permission to work on these.

Comments

@Asjas
Copy link
Contributor

Asjas commented Jan 6, 2018 •
edited

Challenge Name

https://beta.freecodecamp.org/en/challenges/applied-accessibility/improve-accessibility-of-audio-content-with-the-audio-element

Issue Description

The issue with this challenge is that you can use the opening <audio> tag and leave out the closing </audio> tag and the test passes. The test should be checking if the closing tag is also used.

Browser Information

  • Browser Name, Version: Chrome, Version 63.0.3239.108 (Official Build) (64-bit)
  • Operating System: Windows 10 Pro
  • Mobile, Desktop, or Tablet: Desktop

Your Code

<body>
  <header>
    <h1>Real Coding Ninjas</h1>
  </header>
  <main>
    <p>A sound clip of Zersiaxs screen reader in action.</p>

    <audio id="meowClip" controls>
    <source src="https://s3.amazonaws.com/freecodecamp/screen-reader.mp3"  type="audio/mpeg" />

  </main>
</body>

Screenshot

audio
@Asjas Asjas changed the title [Beta] Applied Accessibility - Challenge isn't checking for closing </audio> tag [Beta] Applied Accessibility - Tests fails to check for closing </audio> tag Jan 6, 2018
@raisedadead raisedadead added beta help wanted Open for all. You do not need permission to work on these. labels Jan 6, 2018
anhtran1906 added a commit to fccSeniorSeminar/freeCodeCamp that referenced this issue Jan 26, 2018
@anhtran1906
fix(seed): Add test cases for closing tags
036f6cf 
Added test cases with assert statements

BREAKING CHANGE: no

Closes freeCodeCamp#16415
Closes freeCodeCamp#16424
Closes freeCodeCamp#16423
Closes freeCodeCamp#16422
Closes freeCodeCamp#16420
Closes freeCodeCamp#16419
Closes freeCodeCamp#16417
Closes freeCodeCamp#16414
@anhtran1906 anhtran1906 mentioned this issue Jan 26, 2018
Merged
10 tasks
@mikeATL
Copy link

mikeATL commented Feb 14, 2018 •
edited

This is not working correctly. It does not detect the closing tag and gives an error when it is there.
screen shot 2018-02-14 at 1 14 28 pm

Edit:
I'm using Chrome Version 64.0.3282.140 (Official Build) (64-bit)
OS: OSX 10.13.3

Edit2:
In order to make it work I had to add the id="meowClip" before controls. If it didn't have the id attribute in that exact position, the close tag test failed. There is nothing in the instructions about including an id attribute.
<audio id="meowClip" controls> </audio>

@Gulshanrajput
Copy link

Still facing the issue, tried everything in this thread.

@AaronWands
Copy link

Facing the same problem. It says that there needs to be a closing audio tag but I have one already. Not sure what to do.

@bloo0178
Copy link

I also had the same problem. I removed the id entirely and the test passed.
<audio controls> </audio>

@youngtechlove
Copy link

youngtechlove commented Jun 29, 2018 via email

@freeCodeCamp freeCodeCamp locked and limited conversation to collaborators Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Open for all. You do not need permission to work on these.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@raisedadead @Asjas @AaronWands @Gulshanrajput @mikeATL @youngtechlove @bloo0178