Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable Ukrainian builds #432

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Conversation

scissorsneedfoodtoo
Copy link
Contributor

Checklist:

Like #427, this is split into two parts: #427 (comment)

@scissorsneedfoodtoo scissorsneedfoodtoo marked this pull request as ready for review September 21, 2022 06:13
@scissorsneedfoodtoo scissorsneedfoodtoo requested a review from a team as a code owner September 21, 2022 06:13
@raisedadead
Copy link
Member

raisedadead commented Sep 21, 2022

@scissorsneedfoodtoo actually you want to drop 0dd2f9e and add it afterwords.

Here is the order that needs to be followed:

  1. Enable only the build stage for a language - this is done correctly in c75cf5f
  2. Run the workflow manually with the PR branch selected. This will build a first image we can use and pushes it to the Azure Container Registry.
  3. Go Azure Portal and create a Web App for Containers on the existing Azure App Service Plan, for this first image. Optionally - Do additional steps to map domains, etc.
  4. Return to the PR and enable the deploy stage for the language - that is 0dd2f9e and add it afterwords.
  5. Merge the PR and profit in the next run.

I will improve this messy flow soon when we move to nomad.

@scissorsneedfoodtoo
Copy link
Contributor Author

Ah, thanks for those details @raisedadead.

Sure, I'll drop 0dd2f9e and follow those steps. I'm not sure if I know how to do everything on Azure, but I can reach out in chat if anything.

For now, I'll drop that commit and run the build manually with this branch selected, then add it back in.

@scissorsneedfoodtoo
Copy link
Contributor Author

Just to consolidate updates in one area, I was able to create the App Service for prod / org Ukrainian News images in Azure under freecodecamp-news-org-ukrainian.

The only think I wasn't able to do was add a custom domain, ukrainian.news.cdn.freecodecamp.org. I believe that's because NGINX hasn't been updated yet, though I can't say for sure.

@raisedadead
Copy link
Member

See: https://staff-wiki.freecodecamp.org/docs/flight-manuals/azure/create-asp-webapp-containers and related documentation. I will improve those docs as I go. Hopefully we would not need them soon * wink *.

@raisedadead
Copy link
Member

You can now add the other commit and land this when you are happy.

@raisedadead raisedadead merged commit 0bf9224 into main Sep 21, 2022
@raisedadead raisedadead deleted the feat/enable-ukrainian-builds branch September 21, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants