-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status: add a report for deamon(8) #140
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @kevans91 |
lsalvadore
suggested changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ngortheone. Only a few changes and this is ready to go.
@sergio-carlavilla, @dbaio: Reviewers added to ask for mentor approval. |
ngortheone
force-pushed
the
status_daemon
branch
from
March 24, 2023 14:17
b1ea834
to
be9dcb9
Compare
ngortheone
requested review from
lsalvadore
and removed request for
dbaio and
sergio-carlavilla
March 24, 2023 14:43
pauamma
reviewed
Mar 25, 2023
ngortheone
force-pushed
the
status_daemon
branch
from
March 25, 2023 00:07
be9dcb9
to
8088d2e
Compare
dbaio
reviewed
Mar 25, 2023
ngortheone
force-pushed
the
status_daemon
branch
from
March 25, 2023 01:07
8088d2e
to
89c0643
Compare
Raising visibility about ongoing work, soliciting testing and feedback
Thanks! |
pauamma
approved these changes
Mar 25, 2023
freebsd-git
pushed a commit
that referenced
this pull request
Mar 26, 2023
Reviewed by: status (Pau Amma <pauamma@gundo.com>) Approved by: dbaio (co-mentor) Pull Request: #140
Committed, thanks: d3ce86b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising visibility about ongoing work, soliciting testing and feedback