Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysutils/py-mqttwarn: Update documentation #175

Closed
wants to merge 2 commits into from

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Apr 29, 2023

Dear @dlangille,

following up on your recent commit 53fec21, and my proposal at mqtt-tools/mqttwarn#646 (comment), I am submitting this patch in order to slightly update the documentation for sysutils/py-mqttwarn. Other than this, it fixes a minor typo on a variable within the package Makefile. Let me know about any adjustments you would like to see.

With kind regards,
Andreas.

@dlangille
Copy link
Contributor

There is no direct merging from here into the FreeBSD ports tree.

I can patch my local tree and use --author="Andreas Motl <your-email>" if you like. If so, please le me know what email address to use there. I can also not use --author` if you like.

Also, I can wait until I have more time to figure out the path for doing this as a --cherry-pick

@amotl
Copy link
Contributor Author

amotl commented May 4, 2023

Hi Dan,

if you want to try that procedure, this would be the way to do it with two --cherry-picks.

git remote add temp https://github.com/freebsd/freebsd-ports
git fetch temp
git cherry-pick 36479f3772da87bf8450cf2731195bb05f25b81a
git cherry-pick c6ef6b858d55068fc775bcde32399f8c3ad560e8
git remote remove temp

Otherwise, you can also use my author tag Andreas Motl <andreas.motl@panodata.org>.

Thank you in advance!

With kind regards,
Andreas.

@dlangille
Copy link
Contributor

I tried. I failed.

[22:09 pkg01 dan ~/src/ports/sysutils/py-mqttwarn] % git cherry-pick 36479f3772da87bf8450cf2731195bb05f25b81a
fatal: bad object 36479f3772da87bf8450cf2731195bb05f25b81a

I tried again. Failed same why. So I downloaded the patch and tried another way.

For now, we have this:

commit 35c70b0431781b47c33d8b977e020e18b5480558 (HEAD -> main)
Author: Andreas Motl <andreas.motl@panodata.org>
Date:   Thu May 4 22:19:01 2023 +0000

    sysutils/py-mqttwarn: Rename option REISPUB to REDISPUB
    
    The REISPUB option was spelled wrong. Let's rename it.
    
    While here, add an UPDATING entry to let the users know it changed.

@amotl
Copy link
Contributor Author

amotl commented May 4, 2023

Thanks. b2fdc16 1 would be the more important one. I don't know why cherry-picking fails. You can download it at 2.

Footnotes

  1. Before, it was 36479f3, I've just applied a slight formatting update.

  2. https://github.com/freebsd/freebsd-ports/commit/b2fdc16b7afb48c819ea9bf836cddda56622b484.patch

@amotl
Copy link
Contributor Author

amotl commented May 5, 2023

It looks like the updates made it to https://www.freshports.org/sysutils/py-mqttwarn/ already, on behalf of 35c70b0 and de3dea7. Thank you so much, and sorry for the broken WWW line. Closing this.

@amotl amotl closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants