Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find: Add -readable, -writable & -executable options #1080

Closed
wants to merge 1 commit into from

Conversation

ricardobranco777
Copy link
Contributor

Add -readable, -writable & -executable options for GNU find compatibility. These functions use access() to test for readable/writable/executable access by the current user.

References:

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits i noticed on a first read thru

usr.bin/find/find.1 Outdated Show resolved Hide resolved
usr.bin/find/find.1 Show resolved Hide resolved
usr.bin/find/find.1 Outdated Show resolved Hide resolved
usr.bin/find/option.c Outdated Show resolved Hide resolved
@@ -28,7 +28,9 @@
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE.
.\"
.Dd January 15, 2024
.\" @(#)find.1 8.7 (Berkeley) 5/9/95
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mis-merge with changes in main to remove old SCCS IDs?

@bsdjhb
Copy link
Member

bsdjhb commented Jan 22, 2024

@bsdimp The style violations from the checker are false positives.

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (with @bsdjhb's complaint addressed)

@bsdjhb bsdjhb added the merged label Jan 22, 2024
@bsdjhb
Copy link
Member

bsdjhb commented Jan 22, 2024

Merged in e4b646c, thanks!

@bsdjhb bsdjhb closed this Jan 22, 2024
freebsd-git pushed a commit that referenced this pull request Jan 22, 2024
Reviewed by:	jhb, Mina Galić
Pull Request:	#1080
freebsd-git pushed a commit that referenced this pull request Apr 8, 2024
Reviewed by:	jhb, Mina Galić
Pull Request:	#1080

(cherry picked from commit e4b646c)
@ricardobranco777 ricardobranco777 deleted the find_access branch April 8, 2024 19:40
freebsd-git pushed a commit that referenced this pull request Apr 8, 2024
Reviewed by:	jhb, Mina Galić
Pull Request:	#1080

(cherry picked from commit e4b646c)
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants