-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
at cron file now lives in /etc/cron.d/at #1106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need to be 3 commits.
also see inline comments.
(I still wish github, or literally any forge out there, would render nroff / mdoc files)
@igalic Thanks for all suggestion, fixed! Commits can be squashed into one on merge, if I remember correctly. |
We don't (can't) use the GitHub merge functionality, as GitHub is not the primary repository and does not have direct write access. It is possible for the FreeBSD committer who lands this to edit or squash the commits but we prefer that pull requests have commits prepared in a ready-to-land state. Also please note from CONTRIBUTING.md:
|
usr.sbin/cron/crontab/crontab.5
Outdated
@@ -281,7 +285,16 @@ Note, however, that overlap may occur if the job is running when the file | |||
containing the job is modified and subsequently reloaded. | |||
The first run is scheduled for the specified number of seconds after cron | |||
is started or the crontab entry is reloaded. | |||
.Sh EXAMPLE CRON FILE | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an extra newline and should be removed.
usr.sbin/cron/crontab/crontab.5
Outdated
# note the username as sixth field! | ||
*/5 * * * * root vmstat | ||
.Ed | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
@@ -16,7 +16,7 @@ runs jobs queued by | |||
The system | |||
.Xr crontab 5 | |||
file | |||
.Pa /etc/crontab | |||
.Pa /etc/cron.d/at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already in main, so can be dropped from a rebase.
PR: 243380 Reviewed by: imp Pull Request: freebsd#1106
Add details on the format of system cron files, which are mentioned in cron(8) which refers here but barely explained here. Reviewed by: imp Pull Request: freebsd#1106
Pushed with minor tweaks. |
Sorry this took so long to land... Thanks for fixing this and cross referencing the bug. |
PR: 243380 Reviewed by: imp Pull Request: freebsd/freebsd-src#1106
Add details on the format of system cron files, which are mentioned in cron(8) which refers here but barely explained here. Reviewed by: imp Pull Request: freebsd/freebsd-src#1106
Fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243380