Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ifconfig tunnelfib is implemented in wg(4) #1186

Closed
wants to merge 1 commit into from

Conversation

gshapiro
Copy link
Member

It appears from the wg(4) source code that ifconfig's tunnelfib parameter is available so adding it to the man page.

@emaste
Copy link
Member

emaste commented Apr 19, 2024

CC @kevans91

Copy link
Contributor

@gmshake gmshake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@llfw
Copy link
Contributor

llfw commented Apr 20, 2024

if this line is supposed to enumerate all drivers which support the option, should it say "i.e." rather than "e.g."?

@gmshake
Copy link
Contributor

gmshake commented Apr 21, 2024

if this line is supposed to enumerate all drivers which support the option,

If all ( in-tree ) drivers are enumerated, good.
If not, acceptable.

should it say "i.e." rather than "e.g."?

So I think "e.g." is appropriate here.

@kevans91
Copy link
Contributor

This is indeed expected to work; thanks! (LGTM)

@bsdimp bsdimp added ready and removed needs-review labels Apr 21, 2024
@bsdimp
Copy link
Member

bsdimp commented Apr 21, 2024

Seems ready. Last call...

@bsdimp bsdimp self-assigned this Apr 21, 2024
@bsdimp bsdimp added merged and removed ready labels Apr 23, 2024
@bsdimp
Copy link
Member

bsdimp commented Apr 23, 2024

merged

@bsdimp bsdimp closed this Apr 23, 2024
freebsd-git pushed a commit that referenced this pull request Apr 23, 2024
MFC After: 1 week
Reviewed by: imp, zlei, kevans
Pull Request: #1186
freebsd-git pushed a commit that referenced this pull request May 21, 2024
MFC After: 1 week
Reviewed by: imp, zlei, kevans
Pull Request: #1186

(cherry picked from commit f578d01)
fichtner pushed a commit to opnsense/src that referenced this pull request May 29, 2024
MFC After: 1 week
Reviewed by: imp, zlei, kevans
Pull Request: freebsd/freebsd-src#1186

(cherry picked from commit f578d01)
fichtner pushed a commit to opnsense/src that referenced this pull request Jun 3, 2024
MFC After: 1 week
Reviewed by: imp, zlei, kevans
Pull Request: freebsd/freebsd-src#1186

(cherry picked from commit f578d01)
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Aug 11, 2024
MFC After: 1 week
Reviewed by: imp, zlei, kevans
Pull Request: freebsd/freebsd-src#1186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants