ahc(4): Default to memory mapped IO #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this driver was written it made sense to make this default to off, but these days almost all BIOSses will do the right thing. Furthermore non-mmio communication only works on Intel architectures. So lets default to allowing mmio, but not change the semantics of the AHC_ALLOW_MEMIO flag to not break existing installs. Also document the already existing hint.ahc.<unit>.allow_memio. Signed-off-by: HP van Braam <hp@tmm.cx> Reviewed by: imp (small style tweak) Pull Request: freebsd#1219
bsdimp
reviewed
May 10, 2024
sys/dev/aic7xxx/ahc_pci.c
Outdated
| @@ -144,20 +144,23 @@ ahc_pci_map_registers(struct ahc_softc *ahc) | |||
| regs_type = 0; | |||
| regs_id = 0; | |||
|
|
|||
| // Default to memio | |||
| allow_memio = 1; | |||
|
|
|||
There was a problem hiding this comment.
This is better off as an initializer, imho. Also , we try not to do C++ comments. Tweaked before the push.
There was a problem hiding this comment.
Ah,.I didn't realize that initializers were allowed. I'll keep that in mind for the future, also the comment style, thanks!
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 26, 2024
When this driver was written it made sense to make this default to off, but these days almost all BIOSses will do the right thing. Furthermore non-mmio communication only works on Intel architectures. So lets default to allowing mmio, but not change the semantics of the AHC_ALLOW_MEMIO flag to not break existing installs. Also document the already existing hint.ahc.<unit>.allow_memio. Signed-off-by: HP van Braam <hp@tmm.cx> Reviewed by: imp (small style tweak) Pull Request: freebsd/freebsd-src#1219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this driver was written it made sense to make this default to off, but these days almost all BIOSses will do the right thing. Furthermore non-mmio communication only works on Intel architectures.
So lets default to allowing mmio, but not change the semantics of the
AHC_ALLOW_MEMIOflag to not break existing installs. Also document the already existinghint.ahc.<unit>.allow_memio.