Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manpath.1: align lists + tag spdx #1458

Closed
wants to merge 1 commit into from

Conversation

concussious
Copy link
Contributor

No description provided.

@mhorne mhorne self-assigned this Oct 10, 2024
mhorne pushed a commit to mhorne/freebsd that referenced this pull request Oct 10, 2024
Reviewed by:	mhorne
MFC after:	3 days
Pull Request:	freebsd#1458
@mhorne mhorne closed this Oct 10, 2024
@@ -1,4 +1,6 @@
.\"-
.\" SPDX-License-Identifer: BSD-2-Clause
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit late, but what's the policy for the placement of the SPDX line?

It looks like it's supposed to come after the copyright line, but given the example, perhaps that's only for .c and .h files:
https://docs.freebsd.org/en/articles/license-guide/

The man pages are inconsistent:

Total SPDX lines in man pages

$ git grep "SPDX-License" -- "*.[1-9]" | wc -l
235

SPDX appears 2 lines after Copyright

$ git grep -B2 "SPDX-License" -- "*.[1-9]" | grep "Copyright" | wc -l
17

SPDX appears 2 lines before Copyright

$ git grep -A2 "SPDX-License" -- "*.[1-9]" | grep "Copyright" | wc -l
177

SPDX appears after the license text

$ git grep -B2 "SPDX-License" -- "*.[1-9]" | grep DAMAGE | wc -l
32

There's 3856 man pages without a SPDX-License line. If there's a desire to add SPDX to all of them, a script would save a lot of time. (Same idea as b2c76c4 and fa9896e.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before license if the boilerplate license text is included. After the copyright line if not. Third party code is exempt: wherever so long as both are present.

freebsd-git pushed a commit that referenced this pull request Nov 4, 2024
Reviewed by:	mhorne
MFC after:	3 days
Pull Request:	#1458

(cherry picked from commit d928328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants