fix qcom_cpu_kpssv2 compile on ASUS_AC1300 #776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalic
added a commit
to igalic/freebsd-src
that referenced
this pull request
Jun 11, 2023
follow afdb429 and change the return type from boolean_t to bool for the definition, too. PR: 271932 Reported by: Mina Galić Fixes: afdb429 Pull Request: freebsd#776
igalic
force-pushed
the
fix/ASUS_AC1300-compile
branch
from
e5f67f5
to
df04f92
Compare
follow afdb429 and change the return type from boolean_t to bool for the definition, too. PR: 271932 Reported by: Mina Galić Fixes: afdb429 Pull Request: freebsd#776
igalic
force-pushed
the
fix/ASUS_AC1300-compile
branch
from
df04f92
to
925b5b9
Compare
|
This looks good. Need to tweak the commit message a little (project custom is to not use reported by when you also are fixing the bug) and I reworded the commit message to use only 12 of the characters of the hash and to make it flow a little better. 3ed646d |
|
tested with: works. (merged in 3ed646d ) |
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 14, 2023
Complete afdb429 by changing the return type from boolean_t to bool for the definition for qcom_cpu_kpssv2_regulator_start. PR: 271932 Fixes: afdb429 Pull Request: freebsd/freebsd-src#776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow afdb429 and change the return type
from boolean_t to bool for the definition, too.
PR: 271932
Reported by: Mina Galić
Fixes: afdb429
Pull Request: #776