Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/pax/pax.c: typo #941

Closed
wants to merge 1 commit into from
Closed

Conversation

johnson6841
Copy link
Contributor

Name: Zhan Wei Wu
Email: david5061@gapp.nthu.edu.tw
Line72: same as uflag except inode -> same as uflag except for inode
This is from the Advanced UNIX Programming Course (Fall23) at NTHU.

@bsdimp
Copy link
Member

bsdimp commented Dec 26, 2023

This is good, but in the future, please consider

  1. Adding a one-line summary. In this case 'pax: Add missing word 'for' in comment'
  2. Using the 'Event:' tag rather than just 'from the Advance....' line: 'Event: Advanced...'

@bsdimp bsdimp mentioned this pull request Dec 26, 2023
freebsd-git pushed a commit that referenced this pull request Dec 26, 2023
Event: Advanced UNIX Programming Course (Fall23) at NTHU.
Reviewed by: imp
Pull Request: #941
@bsdimp bsdimp closed this Dec 26, 2023
@bsdimp bsdimp added the merged label Dec 26, 2023
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Mar 13, 2024
Event: Advanced UNIX Programming Course (Fall23) at NTHU.
Reviewed by: imp
Pull Request: freebsd/freebsd-src#941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants