You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In issue #159, handling of SKIP was corrected. However, it seems incomplete to me.
I admit tap specification is somehow vague on Skipping. But I think the example for whole test skip clearly mentions zero in range: 1..0. I have failing test in bind unit tests written using cmocka library. It outputs just
1..0
# ok - tests
Which kyua 0.13 reports as a broken test. It seems fine to me.
Anyway, specification says:
Similarly, one can include an explanation in a plan line, emitted if the test file is skipped completely
I think that means explanation is just nice to have. It makes sense to not parse it then. Instead, range with X..0 should be handled as skip, no matter what is in comment. If that is the case, comments with skip can just be ignored.
The text was updated successfully, but these errors were encountered:
In issue #159, handling of SKIP was corrected. However, it seems incomplete to me.
I admit tap specification is somehow vague on Skipping. But I think the example for whole test skip clearly mentions zero in range: 1..0. I have failing test in bind unit tests written using cmocka library. It outputs just
Which kyua 0.13 reports as a broken test. It seems fine to me.
Anyway, specification says:
I think that means explanation is just nice to have. It makes sense to not parse it then. Instead, range with X..0 should be handled as skip, no matter what is in comment. If that is the case, comments with skip can just be ignored.
The text was updated successfully, but these errors were encountered: