Forgot/ResetPassword

[zahirekrem09]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
wsvvui	✅ Ready (Inspect)	Visit Preview	Jul 22, 2022 at 10:14PM (UTC)

[7alip]

Thank you. I left a small comments about form fields type definition and removing commented out lines.

[7alip]

We can declare ResetPasswordFieldValues to be used instead of FieldValues, so that we will able to see the field value types in the pages/components where we call onSubmit handler.

For example Strapi expect id as number but we might get the id as string from some forms. Type checking will guide us about type conversions in this case.

export type ResetPasswordFieldValues = {
  password: string;
  passwordConfirmation: string;
};

[zahirekrem09]

this part was like you said normally, but since there were type errors in the errors and register props in the FormItem, I had to do it this way.

export type ResetPasswordFieldValues = {
  password: string;
  passwordConfirmation: string;
};

 const {
    register,
    handleSubmit,
    formState: { errors },
  } = useForm<ResetPasswordFieldValues>();

[7alip]

@zahirekrem09 Well, it makes sense then.

You can. maybe fix the lint issues and then merge it.

yarn lint or npx nx affected --target=lint --fix