disable saucelabs #320
Closed
disable saucelabs #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling c9e63ce on soycode-disablesaucelabs into * on master*. |
|
Just to update - looks like similar tests still fail on regular old Shippable, and on Chrome versions as early as 52. Still a pretty opaque failure (timeout on a fairly simple fundamental test), but worth investigating Chrome changelogs and similar to figure out. Hopefully fixes Saucelabs as well. |
|
Alright, belaying this on a hopeful fix for Chrome 52. May end up cutting a release regardless, as whatever the issue is it's not related to recent changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #319
I spent some time trying to persuade Sauce Labs to pass (https://github.com/freedomjs/freedom/tree/soycode-fixtests) but it's a bit opaque so I'm tempted to just call it, at least temporarily. I'll open a "re-enable saucelabs" issue after merging this, but I think it's better to have (informative) green tests than weird failures because Chrome 54 does something strange in Sauce Labs.
Assigning to you Ray as I think you set up Sauce Labs so you may have more insight on this. Thanks!