Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Rework ResponseSendFundsOp #215

Merged
merged 22 commits into from
Jun 15, 2019
Merged

[WIP] Rework ResponseSendFundsOp #215

merged 22 commits into from
Jun 15, 2019

Commits on Jun 12, 2019

  1. Rework ResponseSendFundsOp - part 1

    @pzmarzly
    pzmarzly committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    249ace5 View commit details
    Browse the repository at this point in the history

  2. Rework ResponseSendFundsOp - part 2

    @pzmarzly
    pzmarzly committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    ea22361 View commit details
    Browse the repository at this point in the history

  3. Apply feedback: reword comments

    @pzmarzly
    pzmarzly committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    e890b1b View commit details
    Browse the repository at this point in the history

  4. Apply feedback: is_valid

    @pzmarzly
    pzmarzly committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    e4532c2 View commit details
    Browse the repository at this point in the history

  5. Apply feedback: revert invalid comment change

    @pzmarzly
    pzmarzly committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    bd7f8d2 View commit details
    Browse the repository at this point in the history

  6. Apply feedback: remove is_valid_internal, use is_unique

    @pzmarzly
    pzmarzly committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    a4f7126 View commit details
    Browse the repository at this point in the history

  7. Stop exporting mock_friends_route

    @pzmarzly
    pzmarzly committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    9a74a4b View commit details
    Browse the repository at this point in the history

  8. Improve FriendsRoute tests

    @pzmarzly
    pzmarzly committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    6e21b4e View commit details
    Browse the repository at this point in the history

  9. Reword comments in is_valid

    @pzmarzly
    pzmarzly committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    bb27370 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. Actually remove next node from route [WIP] [ci skip]

    @pzmarzly
    pzmarzly committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    ad318b1 View commit details
    Browse the repository at this point in the history

  2. Remove wrong comment [ci skip]

    @pzmarzly
    pzmarzly committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    dc12ab8 View commit details
    Browse the repository at this point in the history

  3. Get cargo test to pass

    @pzmarzly
    pzmarzly committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    0c8f7b1 View commit details
    Browse the repository at this point in the history

  4. Delete pk_to_index

    @pzmarzly
    pzmarzly committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    fa9d820 View commit details
    Browse the repository at this point in the history

  5. Reword comment as suggested

    @pzmarzly
    pzmarzly committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    be214bd View commit details
    Browse the repository at this point in the history

  6. Move node removal back to handle_request_send_funds

    @pzmarzly
    pzmarzly committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    974efd1 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. Make FriendsRoute::is_valid generic

    @pzmarzly
    pzmarzly committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    9b8db0a View commit details
    Browse the repository at this point in the history

  2. Apply cargo fmt

    @pzmarzly
    pzmarzly committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    19ab683 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2019

  1. Use last() instead of calculating index

    @pzmarzly
    pzmarzly committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    a558c1c View commit details
    Browse the repository at this point in the history

  2. Improve comments in is_route_part_valid

    @pzmarzly
    pzmarzly committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    532f869 View commit details
    Browse the repository at this point in the history

  3. Create non-generic wrappers over route validation functions

    @pzmarzly
    pzmarzly committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    437ae08 View commit details
    Browse the repository at this point in the history

  4. Apply cargo fmt

    @pzmarzly
    pzmarzly committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    ae76c12 View commit details
    Browse the repository at this point in the history

  5. Remove more stale code (freedomlayer#220)

    @pzmarzly
    pzmarzly committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    66f859b View commit details
    Browse the repository at this point in the history