Improve dh-virtualenv for securedrop-client #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extra pip options "--ignore-installed", "--no-deps", and "--no-cache-dir" to the dh-virtualenv override in securedrop-client/debian/rules. This prevents variation in the build environment from changing the set of requirements included in the virtualenv embedded in the package.
| --setuptools \ | ||
| --use-system-packages \ | ||
| --index-url https://dev-bin.ops.securedrop.org/simple \ | ||
| --extra-pip-arg "--ignore-installed" \ |
There was a problem hiding this comment.
very good catch @rmol, we should def add these three extra pip args, --ignore-installed in particular
@kushaldas what do you think of this change?
|
These are the corresponding docs for
All of these look good to me, and testing one package, we should apply these to all the other |
|
hey @rmol when you get a chance feel free to update this PR to make this same change in all python-based packages in this repo and take this out of draft status |
conorsch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra pip options "--ignore-installed", "--no-deps", and "--no-cache-dir" to the dh-virtualenv override in rules files for securedrop-client, securedrop-export, and securedrop-proxy. This prevents variation in the build environment from changing the set of requirements included in the virtualenv embedded in the package.
Fixes #111.