Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #253 adds reproducible testing container #254

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Conversation

kushaldas
Copy link
Contributor

@kushaldas kushaldas commented Jul 9, 2021

This PR adds a new container and also uses it in the CircleCI
to test reproducible wheels and Debian packages. The container
is based on standard Debian Buster, thus having the same version
of Python and environment.

closes #253

How to test?

  • The CI should be green

This PR adds a new container and also uses it in the CircleCI
to test reproducible wheels and Debian packages. The container
is based on standard Debian Buster, thus having the same version
of Python and environment.
@kushaldas kushaldas marked this pull request as ready for review July 9, 2021 15:22
@sssoleileraaa
Copy link
Contributor

updated description to close #253

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few questions as i review this. ci is passing.

@@ -234,29 +234,27 @@ jobs:

reprotest-wheels:
docker:
- image: circleci/python:3.7-buster
- image: quay.io/freedomofpress/packaging-debian-buster@sha256:5e1d3cf73ac6bfe418d499fc419bf789a0d365c51c157b704969d88d2df25e65
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed

.circleci/config.yml Show resolved Hide resolved
@@ -0,0 +1,2 @@
# sha256 digest quay.io/freedomofpress/packaging-debian-buster:2021_07_09
7ac0e1e1c29d9a60e210e0da246a6d60e49c9eab18cf654bacf95ce5fed1413b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be: 5e1d3cf73ac6bfe418d499fc419bf789a0d365c51c157b704969d88d2df25e65? also i'm seeing https://security-tracker.debian.org/tracker/CVE-2019-19814 for this image. trying to see if we have it documented somewhere that this is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be: 5e1d3cf73ac6bfe418d499fc419bf789a0d365c51c157b704969d88d2df25e65? also i'm seeing https://security-tracker.debian.org/tracker/CVE-2019-19814 for this image. trying to see if we have it documented somewhere that this is fine.

I actually have similar question and forgot to put in the comment. The checksum mentioned here is created by our scripts, may be I did a mistake in calling the script. Thank you for pointing out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now fixed with the hash of the newer image.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great I'll take another look at this PR

@kushaldas
Copy link
Contributor Author

Updated the docker image and now it properly matches against the hash in the https://quay.io.

Note to self: there are still many differences between podman and docker.

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI breakage for the reproducible wheels using extensions
2 participants