Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilding securedrop-client wheels for Python3.9 #1494

Merged
merged 1 commit into from
May 24, 2022

Conversation

gonzalo-bulnes
Copy link
Contributor

Description

Updates the wheels to enable buidling the Debian package for Bullseye.

Test Plan

  • Build the package and confirm that the usual build steps do create the package

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

Co-Authored-By: Kunal <kunal@freedom.press>
@legoktm
Copy link
Member

legoktm commented May 24, 2022

We don't need make sync-requirements, so I'm going to remove that from this PR and then merge it, the original commit was actually passing CI, it just needed the wheels to be committed and merged first (freedomofpress/securedrop-builder#328).

@legoktm legoktm force-pushed the rebuild-debian-package-for-bullseye branch from c162e06 to 482ffb6 Compare May 24, 2022 22:15
@legoktm legoktm marked this pull request as ready for review May 24, 2022 22:15
@legoktm legoktm requested a review from a team as a code owner May 24, 2022 22:15
@legoktm legoktm merged commit 26ad8f7 into main May 24, 2022
@legoktm legoktm deleted the rebuild-debian-package-for-bullseye branch May 24, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants