Ensure that the sync and both queue threads are closed before the corresponding QThread instances are destroyed #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalo-bulnes
requested review from
cfm,
sssoleileraaa,
eaon,
legoktm and
rocodes
gonzalo-bulnes
changed the title
gonzalo-bulnes
changed the base branch from
ensure-threads-are-exited-before-qthread-instances-are-destroyed
to
main
20 tasks
gonzalo-bulnes
force-pushed
the
ensure-threads-are-exited-before-qthread-instances-are-destroyed-2
branch
from
7d66bf1
to
a8756b9
Compare
|
(rebased) |
sssoleileraaa
approved these changes
Jun 22, 2022
| @@ -337,6 +337,9 @@ def __init__( # type: ignore [no-untyped-def] | |||
| proxy: bool = True, | |||
| qubes: bool = True, | |||
| export_thread: Optional[QThread] = None, | |||
| sync_thread: Optional[QThread] = None, | |||
There was a problem hiding this comment.
plan is to no longer have default once all tests are fixed up
sssoleileraaa
deleted the
ensure-threads-are-exited-before-qthread-instances-are-destroyed-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🔮 Reviewers rebase this PR after #1512 is merged. Only the last commit needs review 💚
Follows up on #1512 fixing the remaining instances of
QThreadthat were destroyed before the corresponding threads were exited.Fixes #1510 for good. (See #1510 (comment)!)
Test Plan
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
mainand confirmed that the migration applies cleanlymainand would like the reviewer to do so